-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add github actions for ci #853
Conversation
Thanks! :) I think another problem is I hadn't allowed third-party, which may be required for the checkout/setup actions? I've added some of your changes for the next push. I'm trying to get the basics working before I enable the browser, because they chew up a lot of CPU time. :) |
np! did you see the checks? https://github.com/ethers-io/ethers.js/pull/853/checks?check_run_id=717835576 |
Yeah, just saw them. That's awesome. So, I will prolly pull your changes in now... I originally just copied the order their UI build for me. Few quick questions:
|
Filename doesn't matter but you can customize the name of the workflow and the name of the jobs for how you'd like them to display in the check. also shows in the sidebar here https://github.com/ethers-io/ethers.js/actions yeah I used my best defaults. also the img src of the readme badge changes with the Free for public repos is pretty amazing 🥇 💯 🔥 |
It's also trivial to run cron jobs so we have a nightly test run with fresh deps in ethereumjs-vm that's pretty cool (VM Nightly). |
So... much... faster. :) |
yeah i have no idea how they got it so fast but it's probably the best part |
hey :) I found your gh actions workflow that you mentioned.
I found two things:
actions/checkout
was beforeactions/setup-node
bootstrap
was misspelledI also added your browser tests and made sure the workflow runs on updates to PRs and new tags.